Open
Conversation
facebook#7888) Summary: This provides a workaround for two race conditions that will be fixed in a more sophisticated way later. This PR: (1) Makes the client serialize calls to `Timer::Start()` and `Timer::Shutdown()` (see facebook#7711). The long-term fix will be to make those functions thread-safe. (2) Makes `PeriodicWorkScheduler` atomically add/cancel work together with starting/shutting down its `Timer`. The long-term fix will be for `Timer` API to offer more specialized APIs so the client will not need to synchronize. Pull Request resolved: facebook#7888 Test Plan: ran the repro provided in facebook#7881 Reviewers: igor Subscribers: Differential Revision: https://rockset.phacility.com/D25990891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first pass at adding a MockCloudStorageProvider. The Mock Provider treats the "cloud buckets/paths" as alternative directories on the local machine.
By compiling RocksDB with USE_AWS or USE_CLOUD, the "core" RocksDB tests can be run against a cloud environment. This environment can be activated by using TEST_ENV_URI="provider=mock" (to test against the mock provider) or TEST_ENV_URI="id=aws" (to test against AWS/S3).
One db_cloud_test (CopyObjects) is still failing for both Cloud/AWS and the "DirectReads" test also fails for Mock. This testing has exposed a race condition in the scheduler shutdown that needs further investigation. A full test run of the RocksDB test suite against the MockProvider has yet to be undertaken (pending resolution of these other issues).